Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

feat: OPTIC-351: Object3D hackathon POC #1642

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

yyassi-heartex
Copy link
Contributor

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Frontend

Describe the reason for change

(link to issue, supportive screenshots etc.)

What does this fix?

(if this is a bug fix)

What is the new behavior?

(if this is a breaking or feature change)

What is the current behavior?

(if this is a breaking or feature change)

What libraries were added/updated?

(list all with version changes)

Does this change affect performance?

(if so describe the impacts positive or negative)

Does this change affect security?

(if so describe the impacts positive or negative)

What alternative approaches were there?

(briefly list any if applicable)

What feature flags were used to cover this change?

(briefly list any if applicable)

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

@github-actions github-actions bot added the feat label Dec 13, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 1421 lines in your changes are missing coverage. Please review.

Comparison is base (2f5b6e1) 68.28% compared to head (facd3e9) 65.13%.

Files Patch % Lines
src/tags/object/Object3D/Object3D.js 2.10% 389 Missing and 75 partials ⚠️
src/mixins/CubeDrawingTool.js 0.00% 382 Missing ⚠️
src/regions/CubeRegion.js 3.89% 126 Missing and 22 partials ⚠️
src/components/Object3DView/LabelOnRegion.js 9.16% 88 Missing and 21 partials ⚠️
src/tags/object/Object3D/Object3DEntityMixin.js 1.06% 88 Missing and 5 partials ⚠️
src/tags/object/Object3D/Object3DEntity.js 2.66% 70 Missing and 3 partials ⚠️
src/tags/object/Object3D/Object3DSelection.js 1.44% 55 Missing and 13 partials ⚠️
src/tools/Cube.js 0.00% 47 Missing ⚠️
src/components/Object3DView/Object3D.js 26.47% 22 Missing and 3 partials ⚠️
src/tags/object/Object3D/DrawingRegion.js 14.28% 4 Missing and 2 partials ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1642      +/-   ##
==========================================
- Coverage   68.28%   65.13%   -3.16%     
==========================================
  Files         443      458      +15     
  Lines       28686    30162    +1476     
  Branches     7628     7953     +325     
==========================================
+ Hits        19589    19645      +56     
- Misses       7845     9121    +1276     
- Partials     1252     1396     +144     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants